-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fingerprint, Updater script for flyte console. #471
Conversation
Hi @mr-mosi, thank you for your contribution! I'm reviewing your plugin, but I noticed that the As a general rule, the plugin should be able to fingerprint as many versions as possible, especially the latest versions. |
Hi @lokiuox thank you for your review! That's good catch! the I get versions from this address. and you can check them. |
Hi @lokiuox , thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Approved
@maoning you can merge it.
Reviewer: Savio, Doyensec
Plugin: Flyte Console Fingerprints
Feedback: Besides the version.txt
file being initially incomplete, the script worked first try and the quality is good.
Drawbacks: None
Hi, please let me know how can I proceed getting bounty process. thanks. |
Hi @mr-mosi, Please feel in the participation form and let me know when you did so. ~tooryx |
Hi @tooryx |
Hi @mr-mosi, You did not let me know when you submitted the form. We updated the status, you should receive information soon. ~tooryx |
@tooryx thank you. |
Hi dear tsunami team,
Regarding to issue #426
Please note that, Flyte project has various products but all of them use flyteconsole as their dashboard. So as we need web fingerprints of this projects I run flyteconsole to get fingerprints. I used released versions because they were the most downloaded. and there is one or two versions which the release version not identical with git version, so they were ignored.
bests.